fix: application list api is very slow when fields query parameter is supplied #11250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… supplied Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Codecov ReportBase: 45.64% // Head: 45.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11250 +/- ##
=======================================
Coverage 45.64% 45.64%
=======================================
Files 239 239
Lines 28991 28991
=======================================
Hits 13233 13233
Misses 13939 13939
Partials 1819 1819
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
jessesuen
reviewed
Nov 15, 2022
| @@ -17,6 +18,83 @@ import ( | |||
| "github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1" | |||
| ) | |||
|
|
|||
| var appFields = map[string]func(app *v1alpha1.Application) interface{}{ | |||
There was a problem hiding this comment.
Since this is a var that needs to be periodically maintained, for future reference, it would be good to explain what this is for, how its used by UI, and how the fields were chosen and when they need to be updated.
There was a problem hiding this comment.
Good point. Added comment here and in UI code as well
…st/watch api Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
app-list-performance
branch
from
edc6ff3
to
de518ca
Compare
jessesuen
approved these changes
Nov 15, 2022
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Nov 17, 2022
… supplied (argoproj#11250) * fix: application list api is very slow when fields query parameter is supplied Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * regenerate docs Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document the requirement to maintain support fields of application list/watch api Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Nov 23, 2022
… supplied (argoproj#11250) * fix: application list api is very slow when fields query parameter is supplied Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * regenerate docs Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document the requirement to maintain support fields of application list/watch api Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
10 tasks
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
… supplied (argoproj#11250) * fix: application list api is very slow when fields query parameter is supplied Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * regenerate docs Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document the requirement to maintain support fields of application list/watch api Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Depends on argoproj/pkg#243
Application list API method uses gRPC -> HTTP forwarder that provides custom fields functionality. It appears that fields processing is pretty slow. For example API response that returns 5k apps takes ~2 seconds and ~1.8 seconds is required to remove not selected fields.
Implemented PR uses "custom field processor": non generic function that only support specific set of fields. The function is not generic but significantly improves performance of applications list API ( ~ 10x )