Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use new Google Analytics 4 ID (latest) #11291

Merged
merged 1 commit into from Nov 15, 2022

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 14, 2022

/cc @alexmt @alexef @crenshaw-dev

Signed-off-by: Patrice Chalin <chalin@cncf.io>
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 45.65% // Head: 45.65% // No change to project coverage 👍

Coverage data is based on head (c7537dd) compared to base (817161a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11291   +/-   ##
=======================================
  Coverage   45.65%   45.65%           
=======================================
  Files         239      239           
  Lines       28996    28996           
=======================================
  Hits        13238    13238           
  Misses      13939    13939           
  Partials     1819     1819           
Impacted Files Coverage Δ
util/settings/settings.go 51.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexef alexef added only-needs-a-rubber-stamp The author thinks this is low-risk & low-impact, so suggest a cursory review ready-for-review labels Nov 15, 2022
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexmt alexmt merged commit 0240958 into argoproj:master Nov 15, 2022
@alexmt alexmt added cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 labels Nov 15, 2022
@alexmt
Copy link
Collaborator

alexmt commented Nov 15, 2022

will cherry-pick into all release branches to enable analytics in all supported docs versions

@chalin chalin deleted the chalin-gp-ga4-id-2022-11-14 branch November 15, 2022 22:04
@chalin
Copy link
Contributor Author

chalin commented Nov 15, 2022

Thanks!

Looking at the UA data, it seems that v1.8 pages are among the most consulted too. Will you be cherry picking to v1.8?

@chalin chalin changed the title docs: Use new Google Analytics 4 ID docs: Use new Google Analytics 4 ID (latest) Nov 16, 2022
@chalin
Copy link
Contributor Author

chalin commented Nov 16, 2022

For the release-2.5 branch PR with cherrypicks, see:

alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Nov 17, 2022
Signed-off-by: Patrice Chalin <chalin@cncf.io>

Signed-off-by: Patrice Chalin <chalin@cncf.io>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Nov 23, 2022
Signed-off-by: Patrice Chalin <chalin@cncf.io>

Signed-off-by: Patrice Chalin <chalin@cncf.io>
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
Signed-off-by: Patrice Chalin <chalin@cncf.io>

Signed-off-by: Patrice Chalin <chalin@cncf.io>
Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 only-needs-a-rubber-stamp The author thinks this is low-risk & low-impact, so suggest a cursory review ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants