fix(ui): fix sorting of parameters. Make the Remove override button clickable again #11316
Conversation
…again Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Codecov ReportBase: 45.69% // Head: 45.69% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11316 +/- ##
=======================================
Coverage 45.69% 45.69%
=======================================
Files 239 239
Lines 29013 29013
=======================================
Hits 13257 13257
Misses 13934 13934
Partials 1822 1822
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| </div> | ||
| ) | ||
| }); | ||
| if (app.spec.source.helm.values) { |
There was a problem hiding this comment.
Can you add ?'s here to fail gracefully?
app?.spec?.source?.helm?.values
There was a problem hiding this comment.
this is a bit excessive, at least app.spec.source should always be defined (considering rest of this file). but it's better to be safe, than sorry :)
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
…lickable again (argoproj#11316) Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software>
|
@crenshaw-dev should we cherry pick this to 2.5? see #11506 |
…lickable again (#11316) Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software>
|
Cherry-picked onto release-2.5 for 2.5.4. |
…lickable again (argoproj#11316) Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software> Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: Alex Eftimie alex.eftimie@getyourguide.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: