docs: clarify value for disabling tools #11395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although it is implied to set the value for the key to `false`, this explicitly states it to add clarity. Along with some wording changes. Signed-off-by: Nicholas Morey <nicholas@morey.tech>
crenshaw-dev
requested changes
Nov 21, 2022
Codecov ReportBase: 47.29% // Head: 47.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11395 +/- ##
=======================================
Coverage 47.29% 47.29%
=======================================
Files 245 245
Lines 41670 41669 -1
=======================================
Hits 19707 19707
+ Misses 19978 19977 -1
Partials 1985 1985
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Nicholas Morey <nicholas@morey.tech>
|
@crenshaw-dev @alexef can be merged |
|
@crenshaw-dev do you mind merging it ? |
crenshaw-dev
approved these changes
Jan 17, 2023
crenshaw-dev
added a commit
that referenced
this pull request
Jan 18, 2023
* docs: clarify value for disabling tools Although it is implied to set the value for the key to `false`, this explicitly states it to add clarity. Along with some wording changes. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: add use-case for disabling tools Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Nicholas Morey <nicholas@morey.tech> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jan 18, 2023
* docs: clarify value for disabling tools Although it is implied to set the value for the key to `false`, this explicitly states it to add clarity. Along with some wording changes. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: add use-case for disabling tools Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Nicholas Morey <nicholas@morey.tech> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-picked onto release-2.6 and release-2.5. |
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
* docs: clarify value for disabling tools Although it is implied to set the value for the key to `false`, this explicitly states it to add clarity. Along with some wording changes. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: add use-case for disabling tools Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Nicholas Morey <nicholas@morey.tech> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
* docs: clarify value for disabling tools Although it is implied to set the value for the key to `false`, this explicitly states it to add clarity. Along with some wording changes. Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: add use-case for disabling tools Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Nicholas Morey <nicholas@morey.tech> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it is implied to set the value for the key to
false, this explicitly states it to add clarity. Along with some wording changes.Signed-off-by: Nicholas Morey nicholas@morey.tech
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: