fix: upgrade qs to avoid CVE-2022-24999 #11743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added
cherry-pick/2.3
Codecov ReportBase: 47.30% // Head: 47.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11743 +/- ##
=======================================
Coverage 47.30% 47.30%
=======================================
Files 243 243
Lines 41525 41525
=======================================
Hits 19644 19644
Misses 19907 19907
Partials 1974 1974 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
wanghong230
approved these changes
Jan 9, 2023
crenshaw-dev
added a commit
that referenced
this pull request
Jan 10, 2023
* fix: upgrade qs to avoid CVE-2022-24999 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * don't explicitly add dependency Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
removed
cherry-pick/2.3
|
Only the 2.6 cherry pick worked. I'll open new PR(s) for <=2.5.0. |
|
Managed to apply the change to release-2.5 and release-2.4. |
|
I'm going to leave this off 2.3 since it's going EOL very soon, and I'm concerned my questionable conflict resolution will cause regressions. |
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
* fix: upgrade qs to avoid CVE-2022-24999 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * don't explicitly add dependency Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
* fix: upgrade qs to avoid CVE-2022-24999 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * don't explicitly add dependency Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: