Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6 RC1: ArgoCD shouldn't return not generating manifests as path and chart fields are empty when one of two sources do not include path or chart #11770

Closed
3 tasks done
lukas-unity opened this issue Dec 20, 2022 · 1 comment · Fixed by #11773
Assignees
Labels
bug Something isn't working cherry-pick/2.6 multi-source-apps Bugs or enhancements related to multi-source Applications.

Comments

@lukas-unity
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

When application manifest is applied and later synced logs from argocd-repo-server return

"time=\"2022-12-20T10:57:41Z\" level=warning msg=\"not generating manifests as path and chart fields are empty\" source=\"&ApplicationSource{RepoURL:git@github.com:myrepo/helm-test.git,Path:,TargetRevision:lukas-testing,Helm:nil,Kustomize:nil,Directory:nil,Plugin:nil,Chart:,Ref:values,}\"\n"

To Reproduce

Apply application manifest that has 2 sources

application.yaml

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: tempo-vulture
  namespace: argocd
spec:
  project: default
  syncPolicy:
    automated:
      prune: true
      selfHeal: true
  destination:
    server: https://kubernetes.default.svc/
    namespace: lukas
  sources:
  - repoURL: 'https://grafana.github.io/helm-charts'
    chart: tempo-vulture
    targetRevision: 0.2.1
    helm:
      valueFiles:
      - $values/tempo-vulture.yaml
  - repoURL: 'git@github.com:myrepo/helm-test.git'
    targetRevision: lukas-testing
    ref: values

tempo-vulture.yaml

replicas:2

and perform Sync

Expected behavior

this shouldn't be happening as second source only specifies values in the git repo.

Screenshots

Version

Paste the output from `argocd version` here.

```sh
argocd-server: v2.6.0-rc1+81e40d5
  BuildDate: 2022-12-19T16:48:52Z
  GitCommit: 81e40d53fe8eee50b00ab38c4b07b34b3dcd6d25
  GitTreeState: clean
  GoVersion: go1.18.9
  Compiler: gc
  Platform: linux/amd64
  Kustomize Version: v4.5.7 2022-08-02T16:35:54Z
  Helm Version: v3.10.3+g835b733
  Kubectl Version: v0.24.2
  Jsonnet Version: v0.19.1

Logs

"time=\"2022-12-20T10:57:41Z\" level=warning msg=\"not generating manifests as path and chart fields are empty\" source=\"&ApplicationSource{RepoURL:git@github.com:myrepo/helm-test.git,Path:,TargetRevision:lukas-testing,Helm:nil,Kustomize:nil,Directory:nil,Plugin:nil,Chart:,Ref:values,}\"\n"
@lukas-unity lukas-unity added the bug Something isn't working label Dec 20, 2022
@crenshaw-dev crenshaw-dev changed the title ArgoCD shouldn't return not generating manifests as path and chart fields are empty when one of two sources do not include path or chart 2.6 RC1: ArgoCD shouldn't return not generating manifests as path and chart fields are empty when one of two sources do not include path or chart Dec 20, 2022
@crenshaw-dev crenshaw-dev added cherry-pick/2.6 multi-source-apps Bugs or enhancements related to multi-source Applications. labels Dec 20, 2022
@ishitasequeira
Copy link
Member

I think we should remove this log or just change the logging level to Debug instead of Warn..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cherry-pick/2.6 multi-source-apps Bugs or enhancements related to multi-source Applications.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants