Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(redis): explicit bind to redis and sentinel for IPv4 clusters (#11388) #11862

Merged
merged 12 commits into from Jan 10, 2023
Merged

fix(redis): explicit bind to redis and sentinel for IPv4 clusters (#11388) #11862

merged 12 commits into from Jan 10, 2023

Conversation

rumstead
Copy link
Contributor

@rumstead rumstead commented Dec 30, 2022 •
edited

closes #11388

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Dec 30, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@e323880). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head f747262 differs from pull request most recent head b61d031. Consider uploading reports for the commit b61d031 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #11862   +/-   ##
=========================================
  Coverage          ?   47.29%           
=========================================
  Files             ?      245           
  Lines             ?    41665           
  Branches          ?        0           
=========================================
  Hits              ?    19706           
  Misses            ?    19974           
  Partials          ?     1985

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

34fathombelow
34fathombelow requested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your thought process is exactly the same as mine in #11418. Unfortunately I have not been able to reproduce the problem with the clusters I have available to me.

As far as the sentinel bind, if I recall correctly this bind has been removed from the sentinel config starting from Redis:7.0 I'm ok with being explicit on this for now.

manifests/ha/base/redis-ha/chart/values.yaml Show resolved Hide resolved
@rumstead
Copy link
Contributor Author

rumstead commented Jan 4, 2023

Your thought process is exactly the same as mine in #11418. Unfortunately I have not been able to reproduce the problem with the clusters I have available to me.

As far as the sentinel bind, if I recall correctly this bind has been removed from the sentinel config starting from Redis:7.0 I'm ok with being explicit on this for now.

sheesh, should we just use your pr.. sorry about that.

@34fathombelow
Copy link
Member

Your thought process is exactly the same as mine in #11418. Unfortunately I have not been able to reproduce the problem with the clusters I have available to me.
As far as the sentinel bind, if I recall correctly this bind has been removed from the sentinel config starting from Redis:7.0 I'm ok with being explicit on this for now.

sheesh, should we just use your pr.. sorry about that.

Go ahead and use your PR. We are all on the same team, I'm just glad this is fixed.

@rumstead rumstead force-pushed the feat/bind-for-ipv4-cluster branch 2 times, most recently from f7f5580 to 89a67ea Compare January 4, 2023 21:37
34fathombelow
34fathombelow approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you

@crenshaw-dev crenshaw-dev changed the title fix(redis): explicit bind to redis and sentinel for IPv4 clusters #11388 fix(redis): explicit bind to redis and sentinel for IPv4 clusters (#11388) Jan 10, 2023
@crenshaw-dev
Copy link
Collaborator

@rumstead @34fathombelow I see this drops HA support for ipv6-only clusters. Will this negatively impact any users with ipv6-only clusters, or is HA already broken for them?

@crenshaw-dev crenshaw-dev merged commit cd3fe2d into argoproj:master Jan 10, 2023
crenshaw-dev added a commit that referenced this pull request Jan 10, 2023
@rumstead @crenshaw-dev
fix(redis): explicit bind to redis and sentinel for IPv4 clusters (#1…
6ebca0b 
…1388) (#11862)

* fix(redis): explicit bind to redis and sentinel for IPv4 clusters #11388

Signed-off-by: rumstead <rjumstead@gmail.com>

* fix(redis): run manifests generate

Signed-off-by: rumstead <rjumstead@gmail.com>

* fix(redis): run manifests generate

Signed-off-by: rumstead <rjumstead@gmail.com>

* Retrigger CI pipeline

Signed-off-by: rumstead <rjumstead@gmail.com>

Signed-off-by: rumstead <rjumstead@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jan 10, 2023
@rumstead @crenshaw-dev
fix(redis): explicit bind to redis and sentinel for IPv4 clusters (#1…
7b7fa87 
…1388) (#11862)

* fix(redis): explicit bind to redis and sentinel for IPv4 clusters #11388

Signed-off-by: rumstead <rjumstead@gmail.com>

* fix(redis): run manifests generate

Signed-off-by: rumstead <rjumstead@gmail.com>

* fix(redis): run manifests generate

Signed-off-by: rumstead <rjumstead@gmail.com>

* Retrigger CI pipeline

Signed-off-by: rumstead <rjumstead@gmail.com>

Signed-off-by: rumstead <rjumstead@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Collaborator

Cherry-picked onto release-2.6 for 2.6.0-rc3 and release-2.5 for 2.5.6.

@rumstead
Copy link
Contributor Author

@rumstead @34fathombelow I see this drops HA support for ipv6-only clusters. Will this negatively impact any users with ipv6-only clusters, or is HA already broken for them?

This change adds back the support for IPv4, you can see a past PR I did for re-adding the IPv4 support. I believe the removal was unintentional with the redis upgrade. The changes work on dual-stack clusters just not IPv6 only ones.

@rumstead rumstead deleted the feat/bind-for-ipv4-cluster branch January 10, 2023 19:05
@34fathombelow
Copy link
Member

@rumstead @34fathombelow I see this drops HA support for ipv6-only clusters. Will this negatively impact any users with ipv6-only clusters, or is HA already broken for them?

I have not seen anyone running on only IPv6. The upgraded helm chart in 2.5 enabled IPv6 support by default which breaks things for many IPv4 only clusters. This change would operate Redis HA the same as it ran in prior versions. We are now just clarifying that Redis HA will not run in IPv6 only environments. A additional manifest would be required for only IPv6

@crenshaw-dev
Copy link
Collaborator

Thanks, yall!

@34fathombelow 34fathombelow mentioned this pull request Jan 10, 2023
Closed
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
@rumstead @crenshaw-dev @emirot
fix(redis): explicit bind to redis and sentinel for IPv4 clusters (ar…
33bbdd2 
…goproj#11388) (argoproj#11862)

* fix(redis): explicit bind to redis and sentinel for IPv4 clusters argoproj#11388

Signed-off-by: rumstead <rjumstead@gmail.com>

* fix(redis): run manifests generate

Signed-off-by: rumstead <rjumstead@gmail.com>

* fix(redis): run manifests generate

Signed-off-by: rumstead <rjumstead@gmail.com>

* Retrigger CI pipeline

Signed-off-by: rumstead <rjumstead@gmail.com>

Signed-off-by: rumstead <rjumstead@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
@andrewgeller
Copy link

Sad. I run IPv6 only clusters in EKS. I suspect I am not the only one.

schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
@rumstead @crenshaw-dev @schakrad
fix(redis): explicit bind to redis and sentinel for IPv4 clusters (ar…
10f8108 
…goproj#11388) (argoproj#11862)

* fix(redis): explicit bind to redis and sentinel for IPv4 clusters argoproj#11388

Signed-off-by: rumstead <rjumstead@gmail.com>

* fix(redis): run manifests generate

Signed-off-by: rumstead <rjumstead@gmail.com>

* fix(redis): run manifests generate

Signed-off-by: rumstead <rjumstead@gmail.com>

* Retrigger CI pipeline

Signed-off-by: rumstead <rjumstead@gmail.com>

Signed-off-by: rumstead <rjumstead@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@34fathombelow 34fathombelow 34fathombelow approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.5 cherry-pick/2.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to deploy ArgoCD with HA
4 participants
@rumstead @34fathombelow @crenshaw-dev @andrewgeller