Sidecar plugin requires discover command

[nbjohnson]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

When using the plugin sidecar format, even when calling the plugin by name a discover command is still required.

To Reproduce

apiVersion: argoproj.io/v1alpha1
kind: ConfigManagementPlugin
metadata:
  name: my-plugin
spec:
  version: v1.0
  ...
  # no discover command

apiVersion: apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
  name: testapp
spec:
  ...
  template:
    ...
    spec:
      project: test
      source:
        ...
        plugin:
          name: my-plugin-v1.0
          ...

Sidecar log: invalid plugin configuration file. at least one of discover.find.name.command or discover.find.glob or discover.fineName should be non-empty

Expected behavior

The appset runs through the plugin that has been specified by name, not having to put in a dummy discover command.

Screenshots

Version

v2.6.0-rc4

Logs

Paste any relevant application logs here.

[crenshaw-dev]

@gdsoumya would you have time to tackle this?

[gdsoumya]

invalid plugin configuration file. at least one of discover.find.name.command or discover.find.glob or discover.fineName should be non-empty

Sure will take a look at the issue

[gdsoumya]

@crenshaw-dev by removing the need for a discovery mechanism we kind of make it open for mistakes where the plugin specified cannot actually support the app and also a plugin without discovery would not match any app that doesn't explicitly specify it's name are we good with these new limitations?

[crenshaw-dev]

Yep, I think those limitations make sense as long as they're well-documented. I think it would also really help for testing. Users can be certain that their plugin is being invoked.

[gdsoumya]

Sounds good, will get a pr in a few days.

[migueleliasweb]

Did anyone notice the typo in finename - instead of filename?

[nmcostello]

@migueleliasweb I see that too, wonder if it's just in the error log or if there is also a typo in the code somewhere