Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need diffing feature or configuration for unordered or empty list #12033

Open
utpk opened this issue Jan 19, 2023 · 1 comment
Open

Need diffing feature or configuration for unordered or empty list #12033

utpk opened this issue Jan 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@utpk
Copy link

utpk commented Jan 19, 2023

Summary

ArgoCD always show as out-of-sync for unordered or empty list in CRD.
For example with RoleBinding in authorization.openshift.io/v1, this will show as out-of-sync even they have the same meaning.

# empty diff
groupNames: null
---
groupNames: []

or

# unordered list diff
subjects:
- kind: Group
  name: A
- kind: User
  name: B
---
subjects:
- kind: User
  name: B
- kind: Group
  name: A

I've tried to use resource.customizations.ignoreDifferences but we really need to track changes and resource.customizations.knownTypeFields that we cannot find the 'array' data type in default K8s

Proposal

I think we can just simply adding Array/List data type or have some flags to treat the list as unordered one.

@utpk utpk added the enhancement New feature or request label Jan 19, 2023
@DaliGossrani
Copy link

I am still facing the same issue, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants