New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable edit button on App Details Summary and Parameters tabs multi-source apps #12048
fix: disable edit button on App Details Summary and Parameters tabs multi-source apps #12048
Conversation
Codecov ReportBase: 47.44% // Head: 47.44% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #12048 +/- ##
=======================================
Coverage 47.44% 47.44%
=======================================
Files 246 246
Lines 41864 41864
=======================================
Hits 19862 19862
Misses 20004 20004
Partials 1998 1998 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of disabling all edits in the App Summary page, we should only disable the fields which are related to the sources
block. For example, editing the app's labels shouldn't be disabled.
3cdf83b
to
a9c901c
Compare
…plications with multiple sources Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
…le Source apps Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
a9c901c
to
cb37920
Compare
I have addressed the comment. |
…ulti-source apps (#12048) * disable edit button on App Details Summary and Parameters tabs for applications with multiple sources Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * disable editing specific fields in Application Summary Tab for Multiple Source apps Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
…ulti-source apps (argoproj#12048) * disable edit button on App Details Summary and Parameters tabs for applications with multiple sources Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * disable editing specific fields in Application Summary Tab for Multiple Source apps Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
fix: disable edit button on App Details Summary and Parameters tabs multi-source apps
fixes #11757 & #11758
Summary Tab
Parameters Tab
Signed-off-by: ishitasequeira ishiseq29@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: