Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support resource actions for apps in different Namespace (#12114) #12115

Merged
merged 1 commit into from Jan 24, 2023

Conversation

mikebryant
Copy link
Contributor

@mikebryant mikebryant commented Jan 24, 2023

Fixes #12114

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Mike Bryant <mike.bryant@mettle.co.uk>
@mikebryant mikebryant changed the title fix: Support resource actions for apps in different Namespace fix: Support resource actions for apps in different Namespace #12114 Jan 24, 2023
@crenshaw-dev crenshaw-dev changed the title fix: Support resource actions for apps in different Namespace #12114 fix: Support resource actions for apps in different Namespace (#12114) Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 47.38% // Head: 47.38% // No change to project coverage 👍

Coverage data is based on head (b100458) compared to base (bd8777a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12115   +/-   ##
=======================================
  Coverage   47.38%   47.38%           
=======================================
  Files         245      245           
  Lines       41670    41670           
=======================================
  Hits        19745    19745           
  Misses      19937    19937           
  Partials     1988     1988           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@jannfis jannfis merged commit 6069ded into argoproj:master Jan 24, 2023
jannfis pushed a commit that referenced this pull request Jan 24, 2023
Signed-off-by: Mike Bryant <mike.bryant@mettle.co.uk>

Signed-off-by: Mike Bryant <mike.bryant@mettle.co.uk>
jannfis pushed a commit that referenced this pull request Jan 24, 2023
Signed-off-by: Mike Bryant <mike.bryant@mettle.co.uk>

Signed-off-by: Mike Bryant <mike.bryant@mettle.co.uk>
@jannfis
Copy link
Member

jannfis commented Jan 24, 2023

Cherry-picked into release-2.5 and release-2.6

@mikebryant mikebryant deleted the m/12114 branch January 24, 2023 22:33
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
…oj#12115)

Signed-off-by: Mike Bryant <mike.bryant@mettle.co.uk>

Signed-off-by: Mike Bryant <mike.bryant@mettle.co.uk>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
…oj#12115)

Signed-off-by: Mike Bryant <mike.bryant@mettle.co.uk>

Signed-off-by: Mike Bryant <mike.bryant@mettle.co.uk>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 for actions for Application in non-argocd Namespace
2 participants