Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix heading to not include a v for the second version #12218

Merged
merged 1 commit into from Feb 3, 2023
Merged

docs: Fix heading to not include a v for the second version #12218

merged 1 commit into from Feb 3, 2023

Conversation

jsoref
Copy link
Member

@jsoref jsoref commented Jan 30, 2023

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@jsoref
Fix heading to not include a v for the second version
07fbae0 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 47.43% // Head: 47.43% // No change to project coverage 👍

Coverage data is based on head (07fbae0) compared to base (9bd1033).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #12218   +/-   ##
=======================================
  Coverage   47.43%   47.43%           
=======================================
  Files         246      246           
  Lines       41824    41824           
=======================================
  Hits        19838    19838           
  Misses      19990    19990           
  Partials     1996     1996
Impacted Files Coverage Δ
util/settings/settings.go 49.20% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsoref jsoref changed the title doc: Fix heading to not include a v for the second version docs: Fix heading to not include a v for the second version Jan 30, 2023
@crenshaw-dev crenshaw-dev added cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 cherry-pick/2.6 labels Jan 31, 2023
@crenshaw-dev crenshaw-dev merged commit b9f9b78 into argoproj:master Feb 3, 2023
crenshaw-dev pushed a commit that referenced this pull request Feb 3, 2023
@jsoref @crenshaw-dev
docs: Fix heading to not include a v for the second version (#12218)
278fd1e 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
crenshaw-dev pushed a commit that referenced this pull request Feb 3, 2023
@jsoref @crenshaw-dev
docs: Fix heading to not include a v for the second version (#12218)
3d32826 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
crenshaw-dev pushed a commit that referenced this pull request Feb 3, 2023
@jsoref @crenshaw-dev
docs: Fix heading to not include a v for the second version (#12218)
d0551e4 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
crenshaw-dev pushed a commit that referenced this pull request Feb 3, 2023
@jsoref @crenshaw-dev
docs: Fix heading to not include a v for the second version (#12218)
9061ae2 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@crenshaw-dev
Copy link
Collaborator

Cherry-picked onto release-2.6, release-2.5, release-2.4, and release-2.3.

@jsoref jsoref deleted the version-consistency-in-upgrading branch February 3, 2023 15:44
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
@jsoref @schakrad
docs: Fix heading to not include a v for the second version (argoproj…
9999fed 
…#12218)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.3 Candidate for cherry picking into the 2.3 release branch cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 cherry-pick/2.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsoref @crenshaw-dev