Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add documentation on background cascading deletion #12229

Merged

Conversation

toyamagu-2021
Copy link
Member

Signed-off-by: toyamagu2021@gmail.com toyamagu2021@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 47.63% // Head: 47.63% // No change to project coverage 👍

Coverage data is based on head (b357a00) compared to base (7bff6c1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12229   +/-   ##
=======================================
  Coverage   47.63%   47.63%           
=======================================
  Files         246      246           
  Lines       41801    41801           
=======================================
  Hits        19911    19911           
  Misses      19897    19897           
  Partials     1993     1993           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
@jessebye
Copy link

@toyamagu-2021 Thank you for this! These instructions were a lifesaver, all our other attempts to use the background finalizer were not working.

@crenshaw-dev crenshaw-dev merged commit a5112a6 into argoproj:master Jun 21, 2023
5 checks passed
@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 21, 2023
Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.5

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 21, 2023
Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 21, 2023
Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Jun 21, 2023
…4149)

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
Co-authored-by: toyamagu <83329336+toyamagu-2021@users.noreply.github.com>
crenshaw-dev pushed a commit that referenced this pull request Jun 21, 2023
…4150)

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
Co-authored-by: toyamagu <83329336+toyamagu-2021@users.noreply.github.com>
crenshaw-dev pushed a commit that referenced this pull request Jun 21, 2023
…4151)

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
Co-authored-by: toyamagu <83329336+toyamagu-2021@users.noreply.github.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
) (argoproj#14149)

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
Co-authored-by: toyamagu <83329336+toyamagu-2021@users.noreply.github.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
)

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
)

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants