fix: return nil if reading application set was successful #12261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 47.44% // Head: 47.44% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #12261 +/- ##
=======================================
Coverage 47.44% 47.44%
=======================================
Files 246 246
Lines 41864 41864
=======================================
Hits 19862 19862
Misses 20004 20004
Partials 1998 1998
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
ishitasequeira
force-pushed
the
fix-return-appset-cli
branch
from
b7aa85d
to
0708f71
Compare
crenshaw-dev
approved these changes
Feb 3, 2023
crenshaw-dev
pushed a commit
that referenced
this pull request
Feb 3, 2023
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Feb 3, 2023
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…2261) Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the return statement. We need to send nil instead of a formatted error. (Discussion is slack thread)
Signed-off-by: ishitasequeira ishiseq29@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: