chore: rename 'progressive rollouts' to 'progressive syncs' #12265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
mbevc1
approved these changes
Feb 2, 2023
zachaller
approved these changes
Feb 2, 2023
Codecov ReportBase: 47.45% // Head: 47.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #12265 +/- ##
=======================================
Coverage 47.45% 47.45%
=======================================
Files 246 246
Lines 41883 41883
=======================================
Hits 19877 19877
Misses 20008 20008
Partials 1998 1998
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
LGTM. |
wanghong230
approved these changes
Feb 3, 2023
drpaneas
reviewed
Feb 3, 2023
Comment on lines
+16
to
+18
| 1. Pass `--enable-progressive-syncs` to the ApplicationSet controller args. | ||
| 1. Set `ARGOCD_APPLICATIONSET_CONTROLLER_ENABLE_PROGRESSIVE_SYNCS=true` in the ApplicationSet controller environment variables. | ||
| 1. Set `applicationsetcontroller.enable.progressive.syncs: true` in the Argo CD ConfigMap. |
There was a problem hiding this comment.
Suggested change
| 1. Pass `--enable-progressive-syncs` to the ApplicationSet controller args. | |
| 1. Set `ARGOCD_APPLICATIONSET_CONTROLLER_ENABLE_PROGRESSIVE_SYNCS=true` in the ApplicationSet controller environment variables. | |
| 1. Set `applicationsetcontroller.enable.progressive.syncs: true` in the Argo CD ConfigMap. | |
| 1. Pass `--enable-progressive-syncs` to the ApplicationSet controller args. | |
| 2. Set `ARGOCD_APPLICATIONSET_CONTROLLER_ENABLE_PROGRESSIVE_SYNCS=true` in the ApplicationSet controller environment variables. | |
| 3. Set `applicationsetcontroller.enable.progressive.syncs: true` in the Argo CD ConfigMap. |
drpaneas
reviewed
Feb 3, 2023
cmd/argocd-applicationset-controller/commands/applicationset_controller.go
Outdated
Show resolved
Hide resolved
…ontroller.go Co-authored-by: Panagiotis Georgiadis <pgeorgia@redhat.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…syncs Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Feb 6, 2023
* chore: rename 'progressive rollouts' to 'progressive syncs' Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * rename docs file Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update cmd/argocd-applicationset-controller/commands/applicationset_controller.go Co-authored-by: Panagiotis Georgiadis <pgeorgia@redhat.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Panagiotis Georgiadis <pgeorgia@redhat.com>
|
Cherry-picked onto release-2.6 for 2.6.0. |
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…#12265) * chore: rename 'progressive rollouts' to 'progressive syncs' Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * rename docs file Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update cmd/argocd-applicationset-controller/commands/applicationset_controller.go Co-authored-by: Panagiotis Georgiadis <pgeorgia@redhat.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Panagiotis Georgiadis <pgeorgia@redhat.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @christianh814 for the idea. I think this is clearer and avoids clash with Argo Rollouts. The rename is also endorsed by @wmgroot (who wrote the feature) and @zachaller (who is an Approver on Rollouts).