Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix a few typos and grammar mistakes #12280

Merged
merged 1 commit into from Feb 17, 2023

Conversation

SJrX
Copy link
Contributor

@SJrX SJrX commented Feb 3, 2023

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 47.62% // Head: 47.62% // No change to project coverage 👍

Coverage data is based on head (f0b6dcb) compared to base (3d02e01).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12280   +/-   ##
=======================================
  Coverage   47.62%   47.62%           
=======================================
  Files         246      246           
  Lines       41806    41806           
=======================================
  Hits        19911    19911           
  Misses      19902    19902           
  Partials     1993     1993           
Impacted Files Coverage Δ
util/settings/settings.go 49.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Steve Ramage <commits@sjrx.net>
@crenshaw-dev crenshaw-dev added cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 cherry-pick/2.6 labels Feb 17, 2023
@crenshaw-dev crenshaw-dev merged commit fa18490 into argoproj:master Feb 17, 2023
crenshaw-dev pushed a commit that referenced this pull request Feb 17, 2023
Signed-off-by: Steve Ramage <commits@sjrx.net>
Co-authored-by: Steve Ramage <commits@sjrx.net>
@crenshaw-dev crenshaw-dev removed cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5 labels Feb 17, 2023
@crenshaw-dev
Copy link
Collaborator

Cherry-picked back to release-2.6. Others were going to be time consuming due to conflicts.

Thanks @SJrX!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants