fix: don't dump SSG to server logs, change deprecation notice to v2.7 #12285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
crenshaw-dev
reviewed
Feb 3, 2023
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jake <86763948+notfromstatefarm@users.noreply.github.com>
crenshaw-dev
approved these changes
Feb 3, 2023
Codecov ReportBase: 47.45% // Head: 47.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #12285 +/- ##
=======================================
Coverage 47.45% 47.46%
=======================================
Files 246 246
Lines 41883 41885 +2
=======================================
+ Hits 19877 19879 +2
Misses 20008 20008
Partials 1998 1998
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
added a commit
that referenced
this pull request
Feb 3, 2023
…#12285) * fix: don't dump SSG to server logs, change deprecation notice to v2.7 Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> * Update server/server.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jake <86763948+notfromstatefarm@users.noreply.github.com> --------- Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> Signed-off-by: Jake <86763948+notfromstatefarm@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Feb 3, 2023
…#12285) * fix: don't dump SSG to server logs, change deprecation notice to v2.7 Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> * Update server/server.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jake <86763948+notfromstatefarm@users.noreply.github.com> --------- Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> Signed-off-by: Jake <86763948+notfromstatefarm@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-picked onto release-2.6 for 2.6.0-rc8 and release-2.5 for 2.5.11. |
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…argoproj#12285) * fix: don't dump SSG to server logs, change deprecation notice to v2.7 Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> * Update server/server.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jake <86763948+notfromstatefarm@users.noreply.github.com> --------- Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> Signed-off-by: Jake <86763948+notfromstatefarm@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: notfromstatefarm 86763948+notfromstatefarm@users.noreply.github.com
SSG uploads are dumped to the API server logs because it wasn't included in the sensitive API list.
Also, I didn't get around to fully solidifying the SSG feature, so we're pushing the deprecation notice back to v2.7.