feat: Added healthcheck for ArgoEvents EventBus CRD. #12395 #12401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes argoproj#12395 Signed-off-by: lucostus <constantin.winkler@gepardec.com>
Feat. argoproj#12395 Signed-off-by: sgartner03 <simon.gartner@gepardec.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #12401 +/- ##
=======================================
Coverage 49.02% 49.03%
=======================================
Files 246 246
Lines 42519 42519
=======================================
+ Hits 20846 20849 +3
+ Misses 19560 19558 -2
+ Partials 2113 2112 -1 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
We currently have no idea why the E2E tests are failing. @crenshaw-dev could you help us? |
|
As far as I can see, all the tests succeeded. Can someone please have a look into this and maybe merge this? |
Lucostus
approved these changes
Mar 30, 2023
alexef
reviewed
Mar 31, 2023
alexef
approved these changes
Mar 31, 2023
Signed-off-by: Constantin <41841989+Lucostus@users.noreply.github.com>
crenshaw-dev
approved these changes
May 27, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…rgoproj#12401) * Added Healthcheck for ArgoEvent Eventbus CRD fixes argoproj#12395 Signed-off-by: lucostus <constantin.winkler@gepardec.com> * Added Test for EventBus CRD healthcheck Feat. argoproj#12395 Signed-off-by: sgartner03 <simon.gartner@gepardec.com> * changed i to _ for idiomatic lua Signed-off-by: Constantin <41841989+Lucostus@users.noreply.github.com> --------- Signed-off-by: lucostus <constantin.winkler@gepardec.com> Signed-off-by: sgartner03 <simon.gartner@gepardec.com> Signed-off-by: Constantin <41841989+Lucostus@users.noreply.github.com> Co-authored-by: lucostus <constantin.winkler@gepardec.com> Co-authored-by: Constantin <41841989+Lucostus@users.noreply.github.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…rgoproj#12401) * Added Healthcheck for ArgoEvent Eventbus CRD fixes argoproj#12395 Signed-off-by: lucostus <constantin.winkler@gepardec.com> * Added Test for EventBus CRD healthcheck Feat. argoproj#12395 Signed-off-by: sgartner03 <simon.gartner@gepardec.com> * changed i to _ for idiomatic lua Signed-off-by: Constantin <41841989+Lucostus@users.noreply.github.com> --------- Signed-off-by: lucostus <constantin.winkler@gepardec.com> Signed-off-by: sgartner03 <simon.gartner@gepardec.com> Signed-off-by: Constantin <41841989+Lucostus@users.noreply.github.com> Co-authored-by: lucostus <constantin.winkler@gepardec.com> Co-authored-by: Constantin <41841989+Lucostus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12395
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: