fix: trigger ApplicationSet reconciliation for clusters matching cluster generators in matrix or merge generators #12543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrevilain
force-pushed
the
fix/applicationset-clusterSecretEventHandler
branch
from
3b73f63
to
a1db431
Compare
alexandrevilain
changed the title
alexandrevilain
force-pushed
the
fix/applicationset-clusterSecretEventHandler
branch
from
a1db431
to
810da35
Compare
alexandrevilain
changed the title
alexandrevilain
changed the title
alexandrevilain
force-pushed
the
fix/applicationset-clusterSecretEventHandler
branch
from
d4bbd62
to
f7ee3c1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #12543 +/- ##
=======================================
Coverage 47.97% 47.97%
=======================================
Files 246 246
Lines 42101 42155 +54
=======================================
+ Hits 20197 20224 +27
- Misses 19890 19912 +22
- Partials 2014 2019 +5
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
alexandrevilain
force-pushed
the
fix/applicationset-clusterSecretEventHandler
branch
from
f7ee3c1
to
dac1e6d
Compare
crenshaw-dev
requested changes
Mar 17, 2023
alexandrevilain
force-pushed
the
fix/applicationset-clusterSecretEventHandler
branch
2 times, most recently
from
b8ac307
to
4035c28
Compare
|
Hi @crenshaw-dev ! |
…ter generators in matrix or merge generators Signed-off-by: alexandre.vilain <alexandre.vilain@corp.ovh.com>
alexandrevilain
force-pushed
the
fix/applicationset-clusterSecretEventHandler
branch
from
4035c28
to
028e33c
Compare
|
/cherry-pick release-2.5 |
|
/cherry-pick release-2.6 |
crenshaw-dev
approved these changes
Mar 24, 2023
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
…ter generators in matrix or merge generators (#12543) Signed-off-by: alexandre.vilain <alexandre.vilain@corp.ovh.com>
This was referenced Mar 24, 2023
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
…ter generators in matrix or merge generators (#12543) Signed-off-by: alexandre.vilain <alexandre.vilain@corp.ovh.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…ter generators in matrix or merge generators (argoproj#12543) Signed-off-by: alexandre.vilain <alexandre.vilain@corp.ovh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #12542
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: