fix: evaluate all possible refresh reasons for multi-source apps (#12379) (cherry-pick #12576) #12609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
) (#12576) * fix: evaluate all possible refresh reasons for multi-source apps (#12379) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * remove redundant parentheses Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * tests Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * don't auto-sync, it makes tests flaky Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * auto-sync because sync CLI doesn't work for multi-source apps Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * don't require out-of-sync - app may sync quickly Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * timeout 60 Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * fix timeout Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Good bot. |
|
I wonder if we should enable more checks for the cherry-pick PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: evaluate all possible refresh reasons for multi-source apps (#12379) (#12576)
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com