fix: traverse generator tree when getting requeue time (#12407) (cherry-pick #12409) #12611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
* add unit test reproducing Signed-off-by: rumstead <rjumstead@gmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * feat: Begin polishing top bar design (#12327) Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * chore: add dist to path to use our kustomize version (#12352) * chore: add dist to path to use our kustomize version Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * correct path Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * missed a spot Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix: when resource does not exist node menu and resource details shou… (#12360) * fix: when resource does not exist node menu and resource details should still render Signed-off-by: Joshua Helton <jdoghelton@gmail.com> * Retrigger CI pipeline Signed-off-by: Joshua Helton <jdoghelton@gmail.com> --------- Signed-off-by: Joshua Helton <jdoghelton@gmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix: traverse generator tree when getting requeue time Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * fix: traverse generator tree when getting requeue time Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * remove duplicate code Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * Retrigger CI pipeline Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * revert gitignore Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> * update from code review Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> --------- Signed-off-by: rumstead <rjumstead@gmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Joshua Helton <jdoghelton@gmail.com> Co-authored-by: Remington Breeze <remington@breeze.software> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: jphelton <jdoghelton@gmail.com>
crenshaw-dev
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: traverse generator tree when getting requeue time (#12407) (#12409)
Signed-off-by: rumstead rjumstead@gmail.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
chore: add dist to path to use our kustomize version (chore: add dist to path to use our kustomize version #12352)
chore: add dist to path to use our kustomize version
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
fix: when resource does not exist node menu and resource details shou… (fix: when resource does not exist node menu and resource details shou… #12360)
fix: when resource does not exist node menu and resource details should still render
Signed-off-by: Joshua Helton jdoghelton@gmail.com
Signed-off-by: Joshua Helton jdoghelton@gmail.com
Signed-off-by: Joshua Helton jdoghelton@gmail.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: rumstead rjumstead@gmail.com
Signed-off-by: rumstead 37445536+rumstead@users.noreply.github.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Joshua Helton jdoghelton@gmail.com
Co-authored-by: Remington Breeze remington@breeze.software
Co-authored-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Co-authored-by: jphelton jdoghelton@gmail.com