fix: Fix the applicationset kind typo

[tossmilestone]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (9fb7847) 47.79% compared to head (87c408c) 47.79%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #12690   +/-   ##
=======================================
  Coverage   47.79%   47.79%           
=======================================
  Files         246      246           
  Lines       41968    41968           
=======================================
  Hits        20058    20058           
  Misses      19910    19910           
  Partials     2000     2000           

Impacted Files	Coverage Δ
util/settings/settings.go	49.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[morey-tech]

Great catch!

[crenshaw-dev]

@tossmilestone I'm a little hesitant to change that constant, because I'm not sure where/how it's used. Is the typo causing any particular issues?

[tossmilestone]

@crenshaw-dev I found this typo when I want to use the applicatinset kind in my code, and I have to define a constant instead to fix the error. I don't know if other people how to use the constant, but it's obviously an error if you use it as kind string.

[crenshaw-dev]

/cherry-pick release-2.4

[crenshaw-dev]

/cherry-pick release-2.5

[crenshaw-dev]

/cherry-pick release-2.6

[crenshaw-dev]

Thanks, @tossmilestone!

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error 0beda4d7bf72f4236d2d77cb90c8905d2a3dbb8d into temp-cherry-pick-83e8ed-release-2.4

[crenshaw-dev]

Manually cherry-picked onto release-2.4.