Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore gitlab projects w/o repository (#12819) #12820

Merged
merged 2 commits into from Mar 12, 2023
Merged

fix: ignore gitlab projects w/o repository (#12819) #12820

merged 2 commits into from Mar 12, 2023

Conversation

pjoomen
Copy link
Contributor

@pjoomen pjoomen commented Mar 10, 2023 •
edited

Fixes #12819

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Mar 10, 2023 •
edited

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (57544a6) 47.78% compared to head (94ad363) 47.78%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #12820   +/-   ##
=======================================
  Coverage   47.78%   47.78%           
=======================================
  Files         246      246           
  Lines       42011    42019    +8     
=======================================
+ Hits        20073    20078    +5     
- Misses      19937    19939    +2     
- Partials     2001     2002    +1
Impacted Files Coverage Δ
applicationset/services/scm_provider/gitlab.go 73.13% <66.66%> (-0.68%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pjoomen pjoomen force-pushed the bugfix/gitlab_scm_provider_generator branch 2 times, most recently from c2514ef to 9ada43d Compare March 11, 2023 13:19
crenshaw-dev
crenshaw-dev requested changes Mar 11, 2023
View reviewed changes
applicationset/services/scm_provider/gitlab.go Outdated Show resolved Hide resolved
applicationset/services/scm_provider/gitlab.go Outdated Show resolved Hide resolved
@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.4

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.5

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

@pjoomen pjoomen force-pushed the bugfix/gitlab_scm_provider_generator branch 2 times, most recently from 2043d35 to ed8f010 Compare March 11, 2023 22:47
@pjoomen
fix: ignore gitlab projects w/o repository (argoproj#12819)
2ee7faa 
Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>
@pjoomen
chore: Add Redpill Linpro to USERS.md
94ad363 
Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>
@pjoomen pjoomen force-pushed the bugfix/gitlab_scm_provider_generator branch from ed8f010 to 94ad363 Compare March 11, 2023 22:59
jannfis
jannfis approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jannfis jannfis enabled auto-merge (squash) March 12, 2023 00:54
@jannfis jannfis merged commit 2fe132e into argoproj:master Mar 12, 2023
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 2fe132eec746d293dd5878fc25f4252dd4a0be48 into temp-cherry-pick-aa6013-release-2.4

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 12, 2023
@pjoomen
fix: ignore gitlab projects w/o repository (#12819) (#12820)
b99b483 
* fix: ignore gitlab projects w/o repository (#12819)

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>

* chore: Add Redpill Linpro to USERS.md

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>

---------

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>
This was referenced Mar 12, 2023
Merged
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 12, 2023
@pjoomen
fix: ignore gitlab projects w/o repository (#12819) (#12820)
61e4bcb 
* fix: ignore gitlab projects w/o repository (#12819)

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>

* chore: Add Redpill Linpro to USERS.md

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>

---------

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>
crenshaw-dev pushed a commit that referenced this pull request Mar 12, 2023
@gcp-cherry-pick-bot @pjoomen
fix: ignore gitlab projects w/o repository (#12819) (#12820) (#12826)
36a134f 
* fix: ignore gitlab projects w/o repository (#12819)



* chore: Add Redpill Linpro to USERS.md



---------

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>
Co-authored-by: Pip Oomen <oomen@piprograms.com>
crenshaw-dev pushed a commit that referenced this pull request Mar 12, 2023
@gcp-cherry-pick-bot @pjoomen
fix: ignore gitlab projects w/o repository (#12819) (#12820) (#12827)
67379d8 
* fix: ignore gitlab projects w/o repository (#12819)



* chore: Add Redpill Linpro to USERS.md



---------

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>
Co-authored-by: Pip Oomen <oomen@piprograms.com>
alexec pushed a commit to alexec/argo-cd that referenced this pull request Mar 19, 2023
@pjoomen @alexec
fix: ignore gitlab projects w/o repository (argoproj#12819) (argoproj…
0939123 
…#12820)

* fix: ignore gitlab projects w/o repository (argoproj#12819)

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>

* chore: Add Redpill Linpro to USERS.md

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>

---------

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@pjoomen
fix: ignore gitlab projects w/o repository (argoproj#12819) (argoproj…
096db6a 
…#12820)

* fix: ignore gitlab projects w/o repository (argoproj#12819)

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>

* chore: Add Redpill Linpro to USERS.md

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>

---------

Signed-off-by: Pip Oomen <pepijn@redpill-linpro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitLab SCM Provider Generator fails on projects without repository
3 participants
@pjoomen @crenshaw-dev @jannfis