fix: log error when failing to get git client #12876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
3 tasks
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #12876 +/- ##
==========================================
- Coverage 48.92% 48.92% -0.01%
==========================================
Files 246 246
Lines 42360 42362 +2
==========================================
Hits 20724 20724
- Misses 19531 19533 +2
Partials 2105 2105
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ishitasequeira
approved these changes
Mar 20, 2023
|
/cherry-pick release-2.4 |
|
/cherry-pick release-2.5 |
|
/cherry-pick release-2.6 |
jannfis
approved these changes
Mar 23, 2023
Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-pick failed with |
|
Cherry-pick failed with |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
* fix: log error when failing to get git client Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update reposerver/repository/repository.go Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update reposerver/repository/repository.go Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: jannfis <jann@mistrust.net>
crenshaw-dev
added a commit
that referenced
this pull request
Mar 24, 2023
* fix: log error when failing to get git client * Update reposerver/repository/repository.go * Update reposerver/repository/repository.go --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: jannfis <jann@mistrust.net>
|
No need to cherry-pick back further than 2.6. This only applies to multi-source apps, which were introduced in 2.6. |
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* fix: log error when failing to get git client Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update reposerver/repository/repository.go Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update reposerver/repository/repository.go Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: jannfis <jann@mistrust.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.