Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable codeql workflow on cherry-pick branches #12893

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

34fathombelow
Copy link
Member

The codeql workflow is currently running against cherry-pick-* branches and during a pull request. This is causing a failure in the CI.

image

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fa18cb8) 47.80% compared to head (b212dc5) 47.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12893   +/-   ##
=======================================
  Coverage   47.80%   47.80%           
=======================================
  Files         246      246           
  Lines       42085    42085           
=======================================
  Hits        20118    20118           
  Misses      19965    19965           
  Partials     2002     2002           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) March 16, 2023 13:23
@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.4

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.5

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit b9c09b9 into argoproj:master Mar 16, 2023
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error b9c09b9415ad02d31f5787414304846aed97263a into temp-cherry-pick-7ae28a-release-2.4

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 16, 2023
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
@34fathombelow 34fathombelow deleted the cherry-pick-branch-fix branch March 16, 2023 22:39
alexec pushed a commit to alexec/argo-cd that referenced this pull request Mar 19, 2023
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
crenshaw-dev added a commit that referenced this pull request Apr 4, 2023
…12893) (#12899)

* fix codegen

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix codegen

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* chore: disable codeql workflow on cherry-pick branches (#12893)

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Justin Marquis <34fathombelow@protonmail.com>
crenshaw-dev pushed a commit that referenced this pull request Apr 4, 2023
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Co-authored-by: Justin Marquis <34fathombelow@protonmail.com>
crenshaw-dev pushed a commit that referenced this pull request Apr 4, 2023
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
@crenshaw-dev
Copy link
Collaborator

Manually cherry-picked onto release-2.4.

yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants