Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint #12972

Merged
merged 1 commit into from
Mar 23, 2023
Merged

chore: fix lint #12972

merged 1 commit into from
Mar 23, 2023

Conversation

crenshaw-dev
Copy link
Collaborator

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3a28c8a) 48.83% compared to head (526a172) 48.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12972   +/-   ##
=======================================
  Coverage   48.83%   48.83%           
=======================================
  Files         246      246           
  Lines       42281    42281           
=======================================
  Hits        20649    20649           
  Misses      19527    19527           
  Partials     2105     2105           

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev
Copy link
Collaborator Author

/cherry-pick release-2.4

@crenshaw-dev
Copy link
Collaborator Author

/cherry-pick release-2.5

@crenshaw-dev
Copy link
Collaborator Author

/cherry-pick release-2.6

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) March 23, 2023 16:00
@crenshaw-dev crenshaw-dev merged commit 100495d into argoproj:master Mar 23, 2023
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 100495d39b5537bde3bad7cad3d9ea32ab2cca4f into temp-cherry-pick-888da2-release-2.4

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 23, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Mar 23, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Mar 23, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev deleted the fix-lint branch March 23, 2023 17:28
crenshaw-dev added a commit that referenced this pull request Mar 23, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev
Copy link
Collaborator Author

Manually cherry-picked onto release-2.4.

yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants