feat: Add controllerNamespace to .status of an application (#12964) #13081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13081 +/- ##
=======================================
Coverage 48.98% 48.98%
=======================================
Files 249 249
Lines 43066 43067 +1
=======================================
+ Hits 21094 21098 +4
+ Misses 19864 19862 -2
+ Partials 2108 2107 -1
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Huber <kevin.huber@hotmail.com>
ItsKev
force-pushed
the
add-controller-namespace-to-status-of-application
branch
from
3535fba
to
1eaf3de
Compare
ishitasequeira
approved these changes
Apr 10, 2023
|
@jannfis can you PTAL? |
34fathombelow
added
the
apps-in-any-namespace
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
approved these changes
May 27, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…13081) Signed-off-by: Kevin Huber <kevin.huber@hotmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…13081) Signed-off-by: Kevin Huber <kevin.huber@hotmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12964
This pull request introduces the controller namespace to the application's .status. With this feature, users are able to trace back the controller that is responsible for managing the application.
Here are a few examples of how this feature can be useful: (as mentioned in #12964)
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.