fix: --file usage is broken for 'argocd proj create' command #13130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #13130 +/- ##
=======================================
Coverage 49.05% 49.05%
=======================================
Files 246 246
Lines 42566 42569 +3
=======================================
+ Hits 20879 20882 +3
- Misses 19571 19572 +1
+ Partials 2116 2115 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
alexmt
added
the
regression
|
/cherry-pick release-2.7 |
|
/cherry-pick release-2.6 |
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Apr 7, 2023
…j#13130) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
added a commit
that referenced
this pull request
Apr 7, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…j#13130) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…j#13130) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes broken
argocd proj createcommand. The command always fails when--fileflag is used becausereadProjFromURIunconditionally returns error/cherry-pick release-2.7
/cherry-pick release-2.7