feat: support 'helm.sh/resource-policy: keep' helm annotation #13157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13157 +/- ##
==========================================
- Coverage 49.05% 49.03% -0.03%
==========================================
Files 246 247 +1
Lines 42569 42694 +125
==========================================
+ Hits 20882 20933 +51
- Misses 19572 19645 +73
- Partials 2115 2116 +1
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ishitasequeira
approved these changes
Apr 10, 2023
gdsoumya
approved these changes
Apr 10, 2023
jessesuen
approved these changes
Apr 24, 2023
|
This will need to be listed as a v2.8 (or 2.7 if we intend to include in v2.7 release) breaking change since we now keep resources where we didn't. |
|
Oops, sorry. Clicked "Closed" instead of "Comment" |
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
|
Thank you @jessesuen ! Updated upgrade instructions |
|
/cherry-pick release-2.7 |
alexmt
added a commit
that referenced
this pull request
Apr 24, 2023
* feat: support 'helm.sh/resource-policy: keep' helm annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…oj#13157) * feat: support 'helm.sh/resource-policy: keep' helm annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…oj#13157) * feat: support 'helm.sh/resource-policy: keep' helm annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * document annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v2.7 introduced
argocd.argoproj.io/sync-options: Delete=falsethat prevents resource deletion. This PR expands the feature and supportshelm.sh/resource-policy: keepannotation as well.Since Argo CD in general is trying to support helm hooks, so it makes sense to support
helm.sh/resource-policy: keepas well.