Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add short_sha_7 to AppSet generators (#11976) #13199

Merged
merged 3 commits into from
Apr 16, 2023

Conversation

fty4
Copy link
Contributor

@fty4 fty4 commented Apr 12, 2023

Hello everyone,

as in issue #11976 discussed a 7 character sha would help some users to use AppSets.
Therefore this PR will add a 7 character key to use it in the ApplicationSet.

Following keys are added:

Generator PR

  • head_short_sha_7

Generator SCM provider

  • short_sha_7
Checklist
  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

closes #11976

Marco Lecheler marco.lecheler@mercedes-benz.com Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (9b53eeb) 49.05% compared to head (126a821) 49.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13199      +/-   ##
==========================================
+ Coverage   49.05%   49.06%   +0.01%     
==========================================
  Files         246      246              
  Lines       42569    42581      +12     
==========================================
+ Hits        20882    20894      +12     
  Misses      19572    19572              
  Partials     2115     2115              
Impacted Files Coverage Δ
applicationset/generators/pull_request.go 52.23% <100.00%> (+2.23%) ⬆️
applicationset/generators/scm_provider.go 34.19% <100.00%> (+2.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit d4fc854 into argoproj:master Apr 16, 2023
27 checks passed
@fty4 fty4 deleted the feat/head_short_sha_7 branch April 16, 2023 12:37
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…oj#13199)

* feat: add shortSHALength7 variable to AppSet generator PR, SCM

Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>

* feat(test): add test for shortSHALength7 in AppSet

Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>

* docs: add short_sha_7 to AppSet generator docu

Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>

---------

Signed-off-by: Marco Lecheler <marco.lecheler@mercedes-benz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use 7 characters for head_short_sha in PR generator
3 participants