fix: remove false positive for no-discovery cmp; log string, not bytes #13251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
/cherry-pick release-2.7 |
|
/cherry-pick release-2.6 |
|
/cherry-pick release-2.5 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13251 +/- ##
=======================================
Coverage 49.05% 49.05%
=======================================
Files 246 246
Lines 42569 42575 +6
=======================================
+ Hits 20882 20885 +3
- Misses 19572 19574 +2
- Partials 2115 2116 +1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
#13251) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-pick failed with |
|
Cherry-pick failed with |
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
argoproj#13251) (argoproj#13336) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
argoproj#13251) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at a95bc7c
Fix a bug in plugin discovery and improve plugin command logging. The bug fix corrects a typo in
config.gothat caused incorrect plugin configuration detection. The logging improvement usesstderr.String()instead ofstderrinplugin.goto show the error output of plugin commands.