feat: add css to support external custom style #13279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutosh16
force-pushed
the
custom-styles-appbanner
branch
4 times, most recently
from
b241af9
to
bc65cc1
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #13279 +/- ##
==========================================
- Coverage 49.06% 49.06% -0.01%
==========================================
Files 248 248
Lines 42816 42816
==========================================
- Hits 21009 21006 -3
- Misses 19688 19690 +2
- Partials 2119 2120 +1 ☔ View full report in Codecov by Sentry. |
ashutosh16
force-pushed
the
custom-styles-appbanner
branch
7 times, most recently
from
88dd302
to
9cf6eee
Compare
crenshaw-dev
approved these changes
Apr 27, 2023
auto-merge was automatically disabled
April 27, 2023 19:08
Head branch was pushed to by a user without write access
ashutosh16
force-pushed
the
custom-styles-appbanner
branch
3 times, most recently
from
ccc3006
to
99be4ec
Compare
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
ashutosh16
force-pushed
the
custom-styles-appbanner
branch
from
99be4ec
to
b3d18dd
Compare
|
@crenshaw-dev Can we cherry pick this in 2.7? |
|
@ashutosh16 getting feedback here: https://cloud-native.slack.com/archives/C020XM04CUW/p1682970971207939 |
leoluz
added
the
cherry-pick/2.7
|
/cherry-pick release-2.7 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
May 25, 2023
* feat: add external css to customize banner Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix lint Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
May 25, 2023
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…proj#13746) * feat: add external css to customize banner * fix lint --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Co-authored-by: asingh <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* feat: add external css to customize banner Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> * fix lint Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> --------- Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change intended to restrict banners only to applications and not to the entire argocd. With the help of custom-styles, you can customize the look and feel of the components. The change, however, includes adding banners only when the application name contains one of the following characters:
prd, prod, or productionScreen.Recording.2023-04-18.at.9.53.50.AM.mov