chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml

[Juneezee]

The github.com/ghodss/yaml package is no longer actively maintained. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml. It is actively maintained by Kubernetes SIG, and also widely used in K8s projects.

The notable change is that github.com/ghodss/yaml uses gopkg.in/yaml.v2 v2.2.2, but sigs.k8s.io/yaml uses gopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.

I also ran go mod tidy.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (ceed653) 49.01% compared to head (c3926b3) 49.01%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #13292      +/-   ##
==========================================
- Coverage   49.01%   49.01%   -0.01%     
==========================================
  Files         247      247              
  Lines       42685    42685              
==========================================
- Hits        20924    20921       -3     
- Misses      19645    19647       +2     
- Partials     2116     2117       +1     

Impacted Files	Coverage Δ
cmd/argocd/commands/account.go	0.00% <ø> (ø)
cmd/argocd/commands/admin/admin.go	15.33% <ø> (ø)
cmd/argocd/commands/admin/app.go	31.12% <ø> (ø)
cmd/argocd/commands/admin/backup.go	0.00% <ø> (ø)
cmd/argocd/commands/admin/generatespec_utils.go	59.15% <ø> (ø)
cmd/argocd/commands/admin/project_allowlist.go	32.07% <ø> (ø)
cmd/argocd/commands/admin/settings.go	67.50% <ø> (ø)
cmd/argocd/commands/admin/settings_rbac.go	24.48% <ø> (ø)
cmd/argocd/commands/app.go	22.00% <ø> (ø)
cmd/argocd/commands/app_actions.go	0.00% <ø> (ø)
... and 13 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[blakepettersson]

Looks great! It would also be good to update the notification-engine as well.

[Juneezee]

Looks great! It would also be good to update the notification-engine as well.

@blakepettersson Please also review argoproj/notifications-engine#175. I'll update this PR once that has been merged. Thanks

[crenshaw-dev]

Thanks, @Juneezee!

[crenshaw-dev]

@Juneezee once the notifications-engine fix is in, we can open another PR to bump the notifications-engine version. :-)