Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add GoTo Financial ArgoCD user #13317

Merged
merged 2 commits into from
May 28, 2023

Conversation

zufardhiyaulhaq
Copy link
Contributor

We from GoTo Financial heavily use ArgoCD as our GitOps platform.

  1. https://gotofinancial.com/en/blog/gopaysh-the-super-app-for-our-engineers
  2. Migrating to Service Mesh at Scale to Support Billions of $ Transactions https://www.youtube.com/watch?v=OE1Qujq51nM

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Signed-off-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com>
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (0e154b0) 49.01% compared to head (fc08818) 49.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13317      +/-   ##
==========================================
+ Coverage   49.01%   49.05%   +0.04%     
==========================================
  Files         247      249       +2     
  Lines       42685    43119     +434     
==========================================
+ Hits        20921    21152     +231     
- Misses      19647    19855     +208     
+ Partials     2117     2112       -5     

see 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev changed the title docs: add GoTo Financial ArgoCD user chore: add GoTo Financial ArgoCD user May 1, 2023
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks. Thanks @zufardhiyaulhaq!

USERS.md Outdated Show resolved Hide resolved
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zufardhiyaulhaq!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 27, 2023 20:20
@crenshaw-dev crenshaw-dev merged commit d811288 into argoproj:master May 28, 2023
23 checks passed
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
* add GoTo Financial ArgoCD user

Signed-off-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com>

* alphabetical order

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
* add GoTo Financial ArgoCD user

Signed-off-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com>

* alphabetical order

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Zufar Dhiyaulhaq <zufardhiyaulhaq@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants