Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appset): add Pull Request Generator for Azure DevOps Repos #13367

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

robinlieb
Copy link
Member

@robinlieb robinlieb commented Apr 28, 2023

Closes #12663

Pull Request Generators are currently implemented for GitHub, GitLab, GitTea and Bitbucket Server. This PR implements the functionality of Pull Request Generator for Azure DevOps Repos.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@robinlieb robinlieb force-pushed the feat/azuredevops-pr-generator branch from e4d280d to 467797c Compare April 28, 2023 14:58
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.06 🎉

Comparison is base (8388ff7) 49.64% compared to head (23faba9) 49.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13367      +/-   ##
==========================================
+ Coverage   49.64%   49.71%   +0.06%     
==========================================
  Files         258      260       +2     
  Lines       44192    44376     +184     
==========================================
+ Hits        21940    22060     +120     
- Misses      20091    20148      +57     
- Partials     2161     2168       +7     
Impacted Files Coverage Δ
.../apis/application/v1alpha1/applicationset_types.go 31.11% <ø> (ø)
applicationset/generators/pull_request.go 45.00% <25.00%> (-7.95%) ⬇️
...plicationset/services/pull_request/azure_devops.go 60.91% <60.91%> (ø)
...cationset/services/pull_request/bitbucket_cloud.go 91.78% <91.78%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robinlieb robinlieb force-pushed the feat/azuredevops-pr-generator branch from 467797c to 8acbfcb Compare May 7, 2023 19:44
@tal19987
Copy link

tal19987 commented May 8, 2023

When this feature will be merged and released?

@robinlieb robinlieb force-pushed the feat/azuredevops-pr-generator branch 4 times, most recently from 71f4cc5 to 536de4a Compare May 11, 2023 17:19
@GuitaristForEver
Copy link

I have tested this feature on real azure devops service and I can confirm things work well

@robinlieb robinlieb force-pushed the feat/azuredevops-pr-generator branch from 74d414c to 8f8374c Compare May 13, 2023 07:20
GuitaristForEver

This comment was marked as duplicate.

Copy link

@GuitaristForEver GuitaristForEver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this feature on a live Azure DevOps environment and it works as expected

@robinlieb robinlieb force-pushed the feat/azuredevops-pr-generator branch 3 times, most recently from 5f8a870 to 80d59f1 Compare May 25, 2023 18:46
@robinlieb robinlieb force-pushed the feat/azuredevops-pr-generator branch from 80d59f1 to e73d6ae Compare May 29, 2023 08:59
@crenshaw-dev crenshaw-dev changed the title feat: add Pull Request Generator for Azure DevOps Repos feat(appset): add Pull Request Generator for Azure DevOps Repos May 29, 2023
@robinlieb robinlieb force-pushed the feat/azuredevops-pr-generator branch 8 times, most recently from 62bd25b to 2ff0b99 Compare June 5, 2023 04:27
@robinlieb robinlieb force-pushed the feat/azuredevops-pr-generator branch from 2ff0b99 to e7a4239 Compare June 7, 2023 05:01
@GuitaristForEver
Copy link

@crenshaw-dev Hi I see that @robinlieb has implemented the requested changes and e2e tests have passed, Are there any other actions that need to be done?

Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
@robinlieb robinlieb force-pushed the feat/azuredevops-pr-generator branch from e7a4239 to 37c073b Compare June 9, 2023 19:22
@crenshaw-dev crenshaw-dev self-assigned this Jun 10, 2023
@crenshaw-dev
Copy link
Collaborator

@GuitaristForEver nothing else needed for the moment. I plan to go on another review sprint before we cut 2.8-rc1. This will be part of it.

@decodingahmed
Copy link

Hey @crenshaw-dev, we are eagerly awaiting the Azure DevOps support. Do you have a timeline of when this might be available for us to consume? Thanks

@crenshaw-dev crenshaw-dev force-pushed the feat/azuredevops-pr-generator branch from 45ea78c to b77867d Compare June 26, 2023 23:26
@crenshaw-dev
Copy link
Collaborator

Seems I borked the history trying to resolve conflicts. Working on it...

…-generator

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev force-pushed the feat/azuredevops-pr-generator branch from b77867d to 23faba9 Compare June 26, 2023 23:55
@crenshaw-dev
Copy link
Collaborator

k, think we're good to go

@crenshaw-dev crenshaw-dev merged commit 46d4609 into argoproj:master Jun 27, 2023
24 checks passed
@robinlieb robinlieb deleted the feat/azuredevops-pr-generator branch July 5, 2023 06:17
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…proj#13367)

Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…proj#13367)

Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

Please add support for AzureDevOps in Pull Requests Generators applicationset
5 participants