Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove references to ARGOCD_REDIS #13434

Merged

Conversation

crenshaw-dev
Copy link
Collaborator

This env var isn't actually used by any argo-cd or gitops-engine code.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (0cf9dee) 49.61% compared to head (15b4883) 49.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13434      +/-   ##
==========================================
- Coverage   49.61%   49.61%   -0.01%     
==========================================
  Files         256      256              
  Lines       43934    43934              
==========================================
- Hits        21800    21798       -2     
- Misses      19975    19977       +2     
  Partials     2159     2159              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@pasha-codefresh pasha-codefresh merged commit dea3848 into argoproj:master Jun 16, 2023
24 checks passed
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants