feat: support referencing secret in any field of oidc config #13475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13475 +/- ##
==========================================
- Coverage 49.14% 49.13% -0.02%
==========================================
Files 248 248
Lines 42893 42903 +10
==========================================
Hits 21079 21079
- Misses 19695 19703 +8
- Partials 2119 2121 +2
☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
May 28, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…j#13475) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…j#13475) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9680
PR allows referencing secret values in any field of OIDC config.