Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check empty logs array before reduce call in logs view (#13447) #13620

Merged
merged 1 commit into from May 18, 2023
Merged

fix: Check empty logs array before reduce call in logs view (#13447) #13620

merged 1 commit into from May 18, 2023

Conversation

patst
Copy link
Contributor

@patst patst commented May 16, 2023

If no log lines are received (yet) the reduce raises an error and crashes the complete ArgoCDUI

Fixes #13447

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@patst
fix: Reduce of empty array with no initial value for LogsView
f9d597d 
* if not log lines are received (yet) the reduce raises an error and crashes the complete ArgoCDUI

Refs: argoproj#13447

Signed-off-by: patst <patrick.steinig@googlemail.com>
alexmt
alexmt approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Cherry-picking to v2.7!

@alexmt alexmt merged commit ce36b6e into argoproj:master May 18, 2023
23 checks passed
@alexmt alexmt added cherry-pick/2.5 cherry-pick/2.6 cherry-pick/2.7 Candidate for cherry picking into the 2.7 release branch and removed cherry-pick/2.5 cherry-pick/2.6 labels May 18, 2023
@alexmt
Copy link
Collaborator

alexmt commented May 18, 2023

/cherry-pick release-2.7

@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request May 18, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 18, 2023
@patst
fix: Reduce of empty array with no initial value for LogsView (#13620)
0559f25 
* if not log lines are received (yet) the reduce raises an error and crashes the complete ArgoCDUI

Refs: #13447

Signed-off-by: patst <patrick.steinig@googlemail.com>
alexmt pushed a commit that referenced this pull request May 18, 2023
@gcp-cherry-pick-bot @patst
fix: Reduce of empty array with no initial value for LogsView (#13620) (
0794a14 
#13651)

* if not log lines are received (yet) the reduce raises an error and crashes the complete ArgoCDUI

Refs: #13447

Signed-off-by: patst <patrick.steinig@googlemail.com>
Co-authored-by: patst <patrick.steinig@googlemail.com>
@patst patst deleted the fix/13447-reduce-logs-check branch May 18, 2023 20:09
This was referenced May 22, 2023
Closed
Closed
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
@gcp-cherry-pick-bot @patst @schakrad
fix: Reduce of empty array with no initial value for LogsView (argopr…
90844a2 
…oj#13620) (argoproj#13651)

* if not log lines are received (yet) the reduce raises an error and crashes the complete ArgoCDUI

Refs: argoproj#13447

Signed-off-by: patst <patrick.steinig@googlemail.com>
Co-authored-by: patst <patrick.steinig@googlemail.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@patst
fix: Reduce of empty array with no initial value for LogsView (argopr…
e31e600 
…oj#13620)

* if not log lines are received (yet) the reduce raises an error and crashes the complete ArgoCDUI

Refs: argoproj#13447

Signed-off-by: patst <patrick.steinig@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
cherry-pick/2.7 Candidate for cherry picking into the 2.7 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Reduce of empty array with no initial value
2 participants
@patst @alexmt