fix: fix broken helm repo alias/name support #13647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13647 +/- ##
==========================================
+ Coverage 49.22% 49.24% +0.02%
==========================================
Files 248 248
Lines 42828 42838 +10
==========================================
+ Hits 21081 21097 +16
+ Misses 19648 19644 -4
+ Partials 2099 2097 -2
☔ View full report in Codecov by Sentry. |
jessesuen
approved these changes
May 18, 2023
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Jul 15, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
added a commit
to alexmt/argo-cd
that referenced
this pull request
Jul 15, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 15, 2023
…elated helm charts (#14529) * Merge pull request from GHSA-94mc-2ch7-r5r5 Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix broken helm repo alias/name support (#13647) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 15, 2023
…elated helm charts (#14528) * Merge pull request from GHSA-94mc-2ch7-r5r5 Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix broken helm repo alias/name support (#13647) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…elated helm charts (argoproj#14528) * Merge pull request from GHSA-94mc-2ch7-r5r5 Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: fix broken helm repo alias/name support (argoproj#13647) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes bug introduced by this fix. While parsing Chart.yaml repo server should take alias into account.