fix: CMPv2 does not allow symlinks to adjacent files in same git repo. Fixes #13342 (cherry-pick #13360) #13669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-2.7 #13669 +/- ##
===============================================
- Coverage 49.03% 49.02% -0.01%
===============================================
Files 246 246
Lines 42592 42592
===============================================
- Hits 20885 20882 -3
- Misses 19592 19594 +2
- Partials 2115 2116 +1
☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
May 27, 2023
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…Fixes argoproj#13342 (argoproj#13360) (argoproj#13669) fix: CMPv2 does not allow symlinks to adjacent files in same git repo. Fixes argoproj#13342 (argoproj#13360) Signed-off-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> Co-authored-by: Jiacheng Xu <xjcmaxwellcjx@gmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: CMPv2 does not allow symlinks to adjacent files in same git repo. Fixes #13342 (#13360)
fix: CMPv2 does not allow symlinks to adjacent files in same git repo. Fixes #13342 (#13360)
Signed-off-by: Jiacheng Xu xjcmaxwellcjx@gmail.com