Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Stop using the deprecated url format for gitlab instances #13687

Merged
merged 2 commits into from
May 27, 2023

Conversation

tete17
Copy link
Contributor

@tete17 tete17 commented May 22, 2023

The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4ce4885) 49.17% compared to head (0ed4d96) 49.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13687   +/-   ##
=======================================
  Coverage   49.17%   49.18%           
=======================================
  Files         248      248           
  Lines       42874    42874           
=======================================
+ Hits        21083    21086    +3     
+ Misses      19689    19687    -2     
+ Partials     2102     2101    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tete17 tete17 force-pushed the Fix-gitlab-revision-links branch from a9a438c to b4391c9 Compare May 23, 2023 18:56
The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
@tete17 tete17 force-pushed the Fix-gitlab-revision-links branch from 8e0d937 to 0ed4d96 Compare May 26, 2023 20:42
@crenshaw-dev crenshaw-dev changed the title fix: Stop using the deprecated url format for gitlab instances fix(ui): Stop using the deprecated url format for gitlab instances May 27, 2023
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tete17!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 27, 2023 16:29
@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.5

@crenshaw-dev crenshaw-dev merged commit 5662367 into argoproj:master May 27, 2023
25 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 27, 2023
…13687)

* fix: Stop using the deprecated url format for gitlab instances

The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

* docs: Add Urbantz to the list of organizations using argo-cd

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

---------

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 566236747474593d4e0d22a0398ffbcca2ff29aa into temp-cherry-pick-3710e2-release-2.6

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 566236747474593d4e0d22a0398ffbcca2ff29aa into temp-cherry-pick-3710e2-release-2.5

crenshaw-dev pushed a commit that referenced this pull request May 27, 2023
…13687) (#13767)

* fix: Stop using the deprecated url format for gitlab instances

The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed


* docs: Add Urbantz to the list of organizations using argo-cd



---------

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
Co-authored-by: Tete17 <miguel_tete17@hotmail.com>
@tete17
Copy link
Contributor Author

tete17 commented May 28, 2023

Hey @crenshaw-dev thanks for the review.

Do you want me to fix the merge conflicts on the 2.5 & 2.6 branhces?

@crenshaw-dev
Copy link
Collaborator

That would be great, thanks! You can just open PRs against those branches directly.

tete17 added a commit to tete17/argo-cd that referenced this pull request May 28, 2023
…rgoproj#13687)

* fix: Stop using the deprecated url format for gitlab instances

The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

* docs: Add Urbantz to the list of organizations using argo-cd

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

---------

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

(cherry picked from commit 5662367)
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
tete17 added a commit to tete17/argo-cd that referenced this pull request May 28, 2023
…rgoproj#13687)

* fix: Stop using the deprecated url format for gitlab instances

The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

* docs: Add Urbantz to the list of organizations using argo-cd

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

---------

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

(cherry picked from commit 5662367)
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
@tete17
Copy link
Contributor Author

tete17 commented May 28, 2023

Not entirely sure what is the workflow here.

I will cherry pick the commit on local branch on my repo and propose 2 MR against the different release branches. Let me know if I should do it differently.

2.5: #13797
2.6: #13796

crenshaw-dev pushed a commit that referenced this pull request May 28, 2023
…13687) (#13796)

* fix: Stop using the deprecated url format for gitlab instances

The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed


* docs: Add Urbantz to the list of organizations using argo-cd



---------



(cherry picked from commit 5662367)

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
crenshaw-dev pushed a commit that referenced this pull request May 28, 2023
…13687) (#13797)

* fix: Stop using the deprecated url format for gitlab instances

The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed


* docs: Add Urbantz to the list of organizations using argo-cd



---------



(cherry picked from commit 5662367)

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
…rgoproj#13687) (argoproj#13767)

* fix: Stop using the deprecated url format for gitlab instances

The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed

* docs: Add Urbantz to the list of organizations using argo-cd

---------

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
Co-authored-by: Tete17 <miguel_tete17@hotmail.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…rgoproj#13687)

* fix: Stop using the deprecated url format for gitlab instances

The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

* docs: Add Urbantz to the list of organizations using argo-cd

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

---------

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…rgoproj#13687)

* fix: Stop using the deprecated url format for gitlab instances

The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.

Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed
Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

* docs: Add Urbantz to the list of organizations using argo-cd

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>

---------

Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants