fix(ui): Stop using the deprecated url format for gitlab instances (cherry-pick #13687) #13767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…13687) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> * docs: Add Urbantz to the list of organizations using argo-cd Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> --------- Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## release-2.7 #13767 +/- ##
============================================
Coverage 49.00% 49.00%
============================================
Files 246 246
Lines 42599 42599
============================================
Hits 20875 20875
Misses 19608 19608
Partials 2116 2116 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
May 27, 2023
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…rgoproj#13687) (argoproj#13767) * fix: Stop using the deprecated url format for gitlab instances The legacy URLs format has been deprecated since february 2023 and now gitlab is make these urls invalid. Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed * docs: Add Urbantz to the list of organizations using argo-cd --------- Signed-off-by: Miguel Sacristán Izcue <miguel_tete17@hotmail.com> Co-authored-by: Tete17 <miguel_tete17@hotmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(ui): Stop using the deprecated url format for gitlab instances (#13687)
The legacy URLs format has been deprecated since february 2023 and
now gitlab is make these urls invalid.
Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed
Signed-off-by: Miguel Sacristán Izcue miguel_tete17@hotmail.com
Signed-off-by: Miguel Sacristán Izcue miguel_tete17@hotmail.com
Signed-off-by: Miguel Sacristán Izcue miguel_tete17@hotmail.com