Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pre-release to helm tracking strategies #13923

Merged

Conversation

morey-tech
Copy link
Contributor

Closes: #13921

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (99d8024) 49.56% compared to head (905e4b7) 49.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13923   +/-   ##
=======================================
  Coverage   49.56%   49.56%           
=======================================
  Files         256      256           
  Lines       43920    43920           
=======================================
  Hits        21770    21770           
  Misses      19987    19987           
  Partials     2163     2163           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@morey-tech morey-tech force-pushed the 13921-helm-pre-release-tracking branch from a98f59d to d02d25e Compare June 7, 2023 12:34
@morey-tech morey-tech marked this pull request as ready for review June 7, 2023 12:34
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good grammar fix.

@pasha-codefresh
Copy link
Member

LGTM, thank you

@pasha-codefresh pasha-codefresh merged commit 74f2396 into argoproj:master Jun 14, 2023
24 checks passed
@morey-tech morey-tech deleted the 13921-helm-pre-release-tracking branch June 14, 2023 16:15
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add pre-release example to Helm tracking strategies
4 participants