fix(cli): allow argocd cli app command for multi source apps #14256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>
woehrl01
force-pushed
the
allow_cli_app_multi_source
branch
from
e5d2a9d
to
9b0af76
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #14256 +/- ##
==========================================
+ Coverage 49.61% 49.76% +0.14%
==========================================
Files 258 261 +3
Lines 44192 44672 +480
==========================================
+ Hits 21928 22230 +302
- Misses 20104 20256 +152
- Partials 2160 2186 +26
☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
Jul 18, 2023
crenshaw-dev
changed the title
|
/cherry-pick release-2.8 |
|
/cherry-pick release-2.7 |
|
/cherry-pick release-2.6 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 18, 2023
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 18, 2023
crenshaw-dev
pushed a commit
that referenced
this pull request
Jul 18, 2023
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…j#14256) (argoproj#14587) Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> Co-authored-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…j#14256) Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…j#14256) Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #12318
Only syncing on specific revision is currently not supported. In the cli every command is blocked. This lifts the limitations and only restrict on revisions.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.