docs: explicit that ArgoCD hooks replaces the Helm ones #14283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com>
Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com>
NitriKx
force-pushed
the
explicit-in-doc-helm-hooks-ignored
branch
from
e9bbca5
to
296a11e
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #14283 +/- ##
==========================================
- Coverage 49.77% 49.75% -0.02%
==========================================
Files 261 261
Lines 44667 44659 -8
==========================================
- Hits 22233 22222 -11
- Misses 20249 20251 +2
- Partials 2185 2186 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
/cherry-pick release-2.8 |
|
/cherry-pick release-2.7 |
|
/cherry-pick release-2.6 |
|
/cherry-pick release-2.5 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
* docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * docs: add Back Market in the user list Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * Update docs/user-guide/helm.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
* docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * docs: add Back Market in the user list Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * Update docs/user-guide/helm.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
This was referenced Jun 30, 2023
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
* docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * docs: add Back Market in the user list Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * Update docs/user-guide/helm.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
* docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * docs: add Back Market in the user list Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * Update docs/user-guide/helm.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jun 30, 2023
) * docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 * docs: add Back Market in the user list * Update docs/user-guide/helm.md --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Benoît Sauvère <benoit@sauve.re> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jun 30, 2023
) * docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 * docs: add Back Market in the user list * Update docs/user-guide/helm.md --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Benoît Sauvère <benoit@sauve.re> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jun 30, 2023
) * docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 * docs: add Back Market in the user list * Update docs/user-guide/helm.md --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Benoît Sauvère <benoit@sauve.re> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jun 30, 2023
) * docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 * docs: add Back Market in the user list * Update docs/user-guide/helm.md --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Benoît Sauvère <benoit@sauve.re> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…) (argoproj#14288) * docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 * docs: add Back Market in the user list * Update docs/user-guide/helm.md --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Benoît Sauvère <benoit@sauve.re> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * docs: add Back Market in the user list Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * Update docs/user-guide/helm.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * docs: add Back Market in the user list Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * Update docs/user-guide/helm.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46
Obviously feel free to reword this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.