docs: explicit that ArgoCD hooks replaces the Helm ones (cherry-pick #14283) #14288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
* docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * docs: add Back Market in the user list Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> * Update docs/user-guide/helm.md Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
approved these changes
Jun 30, 2023
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…) (argoproj#14288) * docs: explicit that ArgoCD hooks replace the Helm ones After digging a bit in the code, I've found this comment that confirms that if we define some ArgoCD hooks the Helm ones are ignored. https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46 * docs: add Back Market in the user list * Update docs/user-guide/helm.md --------- Signed-off-by: Benoît Sauvère <benoit.sauvere@backmarket.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Benoît Sauvère <benoit@sauve.re> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked docs: explicit that ArgoCD hooks replaces the Helm ones (#14283)
After digging a bit in the code, I've found this comment that confirms
that if we define some ArgoCD hooks the Helm ones are ignored.
https://github.com/argoproj/gitops-engine/blob/425d65e07695a741d90b248f2f365f6a4329c23d/pkg/sync/hook/hook.go#L36C2-L36C46
Signed-off-by: Benoît Sauvère benoit.sauvere@backmarket.com
Signed-off-by: Benoît Sauvère benoit.sauvere@backmarket.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Signed-off-by: Benoît Sauvère benoit.sauvere@backmarket.com
Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com
Co-authored-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com