docs: Adding explanation for CMP yaml/json generation (must be K8S object) (#9471) #14295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Hernandez <christian@chernand.io>
christianh814
changed the title
christianh814
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14295 +/- ##
=======================================
Coverage 49.76% 49.76%
=======================================
Files 261 261
Lines 44659 44659
=======================================
Hits 22225 22225
Misses 20249 20249
Partials 2185 2185 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
Jun 30, 2023
crenshaw-dev
changed the title
|
/cherry-pick release-2.8 |
|
/cherry-pick release-2.7 |
|
/cherry-pick release-2.6 |
|
/cherry-pick release-2.5 |
|
Cherry-pick failed with |
5 tasks
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
…ject) (argoproj#9471) (argoproj#14295) (argoproj#14302) Signed-off-by: Christian Hernandez <christian@chernand.io> Co-authored-by: Christian Hernandez <christianh814@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…ject) (argoproj#9471) (argoproj#14295) Signed-off-by: Christian Hernandez <christian@chernand.io>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…ject) (argoproj#9471) (argoproj#14295) Signed-off-by: Christian Hernandez <christian@chernand.io>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding explanation in the CMP doc that states that
generateshould send a valid Kubernetes Object in either YAML or JSON format. Fixes #9471