-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: managedFieldsManagers example in docs needs double-quotes #14324
Conversation
* is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14324 +/- ##
=======================================
Coverage 49.76% 49.76%
=======================================
Files 261 261
Lines 44676 44676
=======================================
Hits 22232 22232
Misses 20257 20257
Partials 2187 2187 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pgpx , Looks good!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thank you @pgpx!
/cherry-pick release-2.8 |
/cherry-pick release-2.7 |
/cherry-pick release-2.6 |
/cherry-pick release-2.5 |
* is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
* is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
* is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
* is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
…) (#14371) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com> Co-authored-by: Paul Martin <paul.martin@gmail.com>
…) (#14372) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com> Co-authored-by: Paul Martin <paul.martin@gmail.com>
…) (#14374) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com> Co-authored-by: Paul Martin <paul.martin@gmail.com>
…) (#14373) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com> Co-authored-by: Paul Martin <paul.martin@gmail.com>
…proj#14324) (argoproj#14372) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com> Co-authored-by: Paul Martin <paul.martin@gmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
…proj#14324) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
…proj#14324) * is a Yaml special character and must be quoted, otherwise ArgoCD fails to parse and shows an error. Signed-off-by: Paul Martin <paul.martin@gmail.com>
Fixes #14323
On https://argo-cd.readthedocs.io/en/stable/user-guide/diffing/#application-level-configuration the managedFieldsManagers example should have double-quoted the
*
wildcards (e.g."*"
) because*
is a YAML special character, and without this the examples cannot be parsed by ArgoCD (raising an error).