Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added information about scopes (#2782) #14354

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

christianh814
Copy link
Member

Added some more information about the scopes field and what will the default be if the user doesn't provide anything. Fixes #2782

Signed-off-by: Christian Hernandez <christian@chernand.io>
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (ef8dae8) 49.74% compared to head (12e0124) 49.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14354      +/-   ##
==========================================
+ Coverage   49.74%   49.76%   +0.01%     
==========================================
  Files         261      261              
  Lines       44676    44676              
==========================================
+ Hits        22225    22232       +7     
+ Misses      20262    20257       -5     
+ Partials     2189     2187       -2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

christianh814 and others added 2 commits July 6, 2023 07:59
Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Christian Hernandez <christianh814@users.noreply.github.com>
@crenshaw-dev crenshaw-dev changed the title fix: Added information about scopes in the docs - Fixes 2782 docs: Added information about scopes (#2782) Jul 6, 2023
@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.8

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.5

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 6, 2023 15:29
@crenshaw-dev crenshaw-dev merged commit 47015cd into argoproj:master Jul 6, 2023
24 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 6, 2023
* Added information about scopes in the docs

Signed-off-by: Christian Hernandez <christian@chernand.io>

* Apply suggestions from code review

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Christian Hernandez <christianh814@users.noreply.github.com>

---------

Signed-off-by: Christian Hernandez <christian@chernand.io>
Signed-off-by: Christian Hernandez <christianh814@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 47015cd37ce34f99e342e02b57b81e7ea8193a3e into temp-cherry-pick-df5322-release-2.7

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 47015cd37ce34f99e342e02b57b81e7ea8193a3e into temp-cherry-pick-df5322-release-2.6

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 47015cd37ce34f99e342e02b57b81e7ea8193a3e into temp-cherry-pick-df5322-release-2.5

crenshaw-dev pushed a commit that referenced this pull request Jul 6, 2023
* Added information about scopes in the docs



* Apply suggestions from code review




---------

Signed-off-by: Christian Hernandez <christian@chernand.io>
Signed-off-by: Christian Hernandez <christianh814@users.noreply.github.com>
Co-authored-by: Christian Hernandez <christianh814@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
* Added information about scopes in the docs

Signed-off-by: Christian Hernandez <christian@chernand.io>

* Apply suggestions from code review

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Christian Hernandez <christianh814@users.noreply.github.com>

---------

Signed-off-by: Christian Hernandez <christian@chernand.io>
Signed-off-by: Christian Hernandez <christianh814@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
@suzaku suzaku mentioned this pull request Aug 15, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
* Added information about scopes in the docs

Signed-off-by: Christian Hernandez <christian@chernand.io>

* Apply suggestions from code review

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Christian Hernandez <christianh814@users.noreply.github.com>

---------

Signed-off-by: Christian Hernandez <christian@chernand.io>
Signed-off-by: Christian Hernandez <christianh814@users.noreply.github.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs SSO RBAC Scopes Param
3 participants