Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger refresh on changed ignoreDifferences (cherry-pick #12607) #14403

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix: trigger refresh on changed ignoreDifferences (#12607)

  • fix: trigger refresh on changed ignoreDifferences

Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

  • make the tests mean things

Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com


Signed-off-by: Michael Crenshaw 350466+crenshaw-dev@users.noreply.github.com

* fix: trigger refresh on changed ignoreDifferences

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* make the tests mean things

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (7c4eee2) 49.75% compared to head (56ddf96) 49.74%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.8   #14403      +/-   ##
===============================================
- Coverage        49.75%   49.74%   -0.01%     
===============================================
  Files              261      261              
  Lines            44697    44701       +4     
===============================================
- Hits             22238    22237       -1     
- Misses           20274    20278       +4     
- Partials          2185     2186       +1     
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 59.02% <0.00%> (-0.10%) ⬇️
controller/appcontroller.go 53.89% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit 00d995d into release-2.8 Jul 11, 2023
20 of 23 checks passed
@crenshaw-dev crenshaw-dev deleted the cherry-pick-b33d61-release-2.8 branch July 11, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant